minus-squarespacedogroy@feddit.uktoGolang@programming.dev•Are code reviews allowed? I wrote a pretty basic RBAC module while working on a separate learning project and was hoping to get the opinion of more experienced GopherslinkfedilinkEnglisharrow-up2·6 months agoI haven’t gone through it thoroughly but the first thing that stuck out was the use of a default logger. I don’t think libraries should log by default. If you do allow a logger to be injected in I think it should be an interface. linkfedilink
spacedogroy@feddit.uk to Golang@programming.devEnglish · 2 years agoFixing For Loops in Go 1.22 - The Go Programming Languageplus-squarego.devexternal-linkmessage-square0fedilinkarrow-up11arrow-down10
arrow-up11arrow-down1external-linkFixing For Loops in Go 1.22 - The Go Programming Languageplus-squarego.devspacedogroy@feddit.uk to Golang@programming.devEnglish · 2 years agomessage-square0fedilink
I haven’t gone through it thoroughly but the first thing that stuck out was the use of a default logger. I don’t think libraries should log by default. If you do allow a logger to be injected in I think it should be an interface.